Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create timeline on opening Loader UI #9

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Do not create timeline on opening Loader UI #9

merged 2 commits into from
Jul 18, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 8, 2024

Changes

Do not create timeline when opening the Loader UI or on calling get_current_timeline_items

Testing notes

  1. Loading clips and media should still work, even when no timeline currently exists in project.
  2. Manager should still work, even when no timeline currently exists in project.
  3. Loading clip should still create timeline when loading into timeline.

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Jul 8, 2024
jakubjezek001
jakubjezek001 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect solution, thanks!

@jakubjezek001 jakubjezek001 merged commit 9f2e083 into ynput:develop Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@jakubjezek001 jakubjezek001

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BigRoy @jakubjezek001