Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering options for texture sets #22

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to add support for filtering texture sets for texture instances. Users can choose which texture set(s) with Export Texture Set(s) they want to export in Ayon. If they leave the options empty, the system will export all texture sets as default.
Resolve #21, #18
image

Additional review information

N/A

Testing notes:

  1. Launch Substance Painter
  2. Create Texture Instance with/without Export Texture Set(s)
  3. Publish

@moonyuet moonyuet added the type: enhancement Improvement of existing functionality or minor addition label Nov 25, 2024
@moonyuet moonyuet self-assigned this Nov 25, 2024
@moonyuet moonyuet requested a review from BigRoy November 26, 2024 08:43
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test - but code looks good to me. Just the one remainder attribute def tooltip comment.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does work when only selected texture set been chosen

Screenshot 2024-12-02 152809

but it does not work when no texture_set been selected and kept empty (aka no texture set).

Then instead of producing all the present texture_sets images produce nothing...

Screenshot 2024-12-02 152944

@moonyuet moonyuet requested a review from LiborBatek December 3, 2024 08:27
@moonyuet moonyuet requested a review from BigRoy December 3, 2024 10:39
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but code looks fine to me.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like charm now!

I have done multiple tests and combos to publish just selected texture_set with diff channels selected etc.

All working nicely!

@moonyuet moonyuet merged commit 37a1906 into develop Dec 3, 2024
1 check passed
@moonyuet moonyuet deleted the enhancement/AY-7196_Allow-publish-selection-of-texture_set-only branch December 3, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-7196_Allow to apply a filter on publish
3 participants