-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project_name as part of the container data #24
Add project_name as part of the container data #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test but code looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im able to load from Library project
and have it displayed with proper name
but I cant Manage
the asset using Switch Folder
and getting error
[Python] Traceback (most recent call last):
[Python] File "C:\Work\REPO\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 403, in <lambda>
[Python] lambda: self._show_switch_dialog(item_ids))
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] File "C:\Work\REPO\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 919, in _show_switch_dialog
[Python] for container_id, container_item in container_items_by_id.values():
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] TypeError
[Python] :
[Python] cannot unpack non-iterable ContainerItem object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have re-test it and it is working fine.
LGTM
…-a-library-project
Changelog Description
This PR is to add project_name as part of the container data regarding to the implementation of ynput/ayon-core#1005
Additional review information
Test along with the installed addon with ynput/ayon-core#1005
Testing notes: