Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project_name as part of the container data #24

Merged

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to add project_name as part of the container data regarding to the implementation of ynput/ayon-core#1005

Additional review information

Test along with the installed addon with ynput/ayon-core#1005

Testing notes:

  1. Launch SP
  2. Load Mesh

@moonyuet moonyuet self-assigned this Nov 28, 2024
@moonyuet moonyuet added the type: enhancement Improvement of existing functionality or minor addition label Nov 28, 2024
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but code looks good to me.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im able to load from Library project and have it displayed with proper name

image

but I cant Manage the asset using Switch Folder and getting error

[Python] Traceback (most recent call last):

[Python]   File "C:\Work\REPO\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 403, in <lambda>

[Python] lambda: self._show_switch_dialog(item_ids))
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python]   File "C:\Work\REPO\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 919, in _show_switch_dialog

[Python] for container_id, container_item in container_items_by_id.values():
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] ^
[Python] TypeError
[Python] : 
[Python] cannot unpack non-iterable ContainerItem object

@moonyuet
Copy link
Member Author

moonyuet commented Dec 3, 2024

Im able to load from Library project and have it displayed with proper name

image

Can you try by git pull the related ayon-core branch and re-test it again?

@moonyuet moonyuet requested a review from LiborBatek December 3, 2024 08:53
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-test it and it is working fine.

LGTM

@moonyuet moonyuet merged commit 294a533 into develop Dec 5, 2024
1 check passed
@moonyuet moonyuet deleted the enhancement/Load-and-manage-products-from-a-library-project branch December 5, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants