generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve the channel map filtering #6
Merged
moonyuet
merged 7 commits into
develop
from
enhancement/AY-6179_SP-redshift-template-support
Jul 30, 2024
Merged
improve the channel map filtering #6
moonyuet
merged 7 commits into
develop
from
enhancement/AY-6179_SP-redshift-template-support
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - did have some cosmetic notes. Couldn't test myself.
Might need a test-run by @LiborBatek ?
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
LiborBatek
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iLLiCiTiT
added
the
type: enhancement
Improvement of existing functionality or minor addition
label
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
The channel map export in the latest develop cannot filter some maps when the maps include similar names (i.e. Color and EmissionColor). This PR is to make sure the current channel map filtering would filter the maps as expected.
Additional info
n/a
Testing notes:
Launch Substance Painter with your project
Create Texture Set
Use RsMaterialTemplate and add base color. Following the setting as the screenshots showed. "Channel Type should be
_Color
for BaseColor if you are using RsMaterialTemplate"Publish
It should only publish Color Map.