Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the channel map filtering #6

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Jul 29, 2024

Changelog Description

The channel map export in the latest develop cannot filter some maps when the maps include similar names (i.e. Color and EmissionColor). This PR is to make sure the current channel map filtering would filter the maps as expected.
image

Additional info

n/a

Testing notes:

  1. Launch Substance Painter with your project

  2. Create Texture Set

  3. Use RsMaterialTemplate and add base color. Following the setting as the screenshots showed. "Channel Type should be _Color for BaseColor if you are using RsMaterialTemplate"
    image
    image

  4. Publish

  5. It should only publish Color Map.

@moonyuet moonyuet requested review from BigRoy and LiborBatek July 29, 2024 05:44
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - did have some cosmetic notes. Couldn't test myself.

Might need a test-run by @LiborBatek ?

server/settings/creator_plugins.py Outdated Show resolved Hide resolved
server/settings/creator_plugins.py Outdated Show resolved Hide resolved
server/settings/creator_plugins.py Outdated Show resolved Hide resolved
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed testing steps and all working fine...

I was able to produce publish for rsMaterial and Color channel only without any errors shown.

Screenshot 2024-07-30 094517

@moonyuet moonyuet merged commit b1628db into develop Jul 30, 2024
1 check passed
@moonyuet moonyuet deleted the enhancement/AY-6179_SP-redshift-template-support branch July 30, 2024 08:04
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants