Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-6740_CSV ingest: version column optional #16

Closed
ynbot opened this issue Sep 16, 2024 · 3 comments · Fixed by #32
Closed

AY-6740_CSV ingest: version column optional #16

ynbot opened this issue Sep 16, 2024 · 3 comments · Fixed by #32
Assignees
Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Comments

@ynbot
Copy link
Contributor

ynbot commented Sep 16, 2024

Please describe the enhancement you have in mind and explain what the current shortcomings are?

Client have been discussing AOV publishing a bit recently, so this might be a potential workflow for now. But their preference would be to develop a new publishing creator for Tray publisher for passes. But it feels like this CSV workflow isn't far off what I was asking for.

Current problem is that version column is required / hardcoded. This might be couple lines change to enhance the workflow for next available version.

How would you imagine the implementation of the enhancemenent?

No response

Describe alternatives you've considered:

No response

Additional context:

()
(might be a private channel)

This issue was automatically created from Clickup ticket AY-6740

@ynbot ynbot added enhancement sponsored This is directly sponsored by a client or community member labels Sep 16, 2024
@iLLiCiTiT iLLiCiTiT added type: enhancement Improvement of existing functionality or minor addition and removed enhancement labels Sep 17, 2024
@jakubjezek001 jakubjezek001 self-assigned this Sep 19, 2024
@BigRoy
Copy link
Contributor

BigRoy commented Oct 7, 2024

I suppose this will need to allow to be an optional attribute:

Anyway, as soon as instance.data["version"] is not set, like it would get popped out of here:

Then it will automatically compute the version of an instance during publishing.
However, it does disallow to publish multiple versions into one product of course. (Which may then need to 're-enable' a certain validation which I think we skipped for csv publishes?)

@robin-ynput
Copy link
Contributor

robin-ynput commented Oct 8, 2024

Then it will automatically compute the version of an instance during publishing.
However, it does disallow to publish multiple versions into one product of course. (Which may then need to 're-enable' a certain validation which I think we skipped for csv publishes?)

@BigRoy if that's OK with you, I'd say let's discuss this concern on the PR directly: #32
To answer quickly, the way this is done now allows you to publish multiple versions into one product, but only 1 of them can be implicit version number, otherwise instances will conflict indeed.

@BigRoy
Copy link
Contributor

BigRoy commented Oct 8, 2024

Actually - only allowing one implicit sounds perfectly fine if that works. In that case 🎩 hat off to you. Sounds perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants