Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-6740 CSV ingest: make Version column optional. #32

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Oct 8, 2024

Changelog Description

These changes resolves #16
Ensure the Version column in the CSV is optional:

  • When it exists and it's filled up, will publish and enforce provided version (previous behavior)
  • When it exists but it's empty, product will take next available version
  • When it does not exist, default logic applies, product will take next available version

Additional info

Testing notes:

Tested via the command line and interactive mode using:

How to use the CSV CLI interface

  1. Create the relevant shot hierarchy in the project
  2. Ensure CSV settings are properly set and OCIO config is enabled
  3. Download resource material and edit CSV to point toward downloading paths
  4. Run the CSV ingest via CLI or interactive mode (traypublisher)

@robin-ynput robin-ynput self-assigned this Oct 8, 2024
@robin-ynput robin-ynput added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Oct 8, 2024
@robin-ynput robin-ynput marked this pull request as ready for review October 8, 2024 19:16
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I could not test it at the moment. But the code seems to be fine and @BigRoy tests were also passing, so perfect work!

@BigRoy BigRoy merged commit f7dea3f into develop Oct 10, 2024
1 check passed
@BigRoy BigRoy deleted the feature/AY-6740_csv_optional_version_column branch October 10, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-6740_CSV ingest: version column optional
3 participants