pyproject.toml: six is a required dependency #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not installed, a clean/fresh install results in: $ bmaptool --version Traceback (most recent call last): File "/2opt/devel/bmaptool/venv.python3.11/bin/bmaptool", line 5, in <module> from bmaptool.CLI import main File "/2opt/devel/bmaptool/venv.python3.11/lib64/python3.11/site-packages/bmaptool/CLI.py", line 42, in <module> from . import BmapCreate, BmapCopy, BmapHelpers, TransRead File "/2opt/devel/bmaptool/venv.python3.11/lib64/python3.11/site-packages/bmaptool/TransRead.py", line 36, in <module> from six.moves.urllib import parse as urlparse ModuleNotFoundError: No module named 'six' Signed-off-by: Trevor Woerner <[email protected]>
|
I think this is required after #12 |
The unit tests shouldn't depend on the dev dependencies, install normal dependencies to ensure the dependecy list is accurate for regular users/installs. Signed-off-by: Trevor Woerner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not installed, a clean/fresh install results in: