Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format code with black #8

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Format code with black #8

merged 4 commits into from
Mar 22, 2024

Conversation

JPEWdev
Copy link
Collaborator

@JPEWdev JPEWdev commented Mar 22, 2024

Formats the code with black and adds a github action to enforce it in CI

@JPEWdev
Format code with black
0228a23 
Formats the code with black and adds a github action to enforce it in CI

Signed-off-by: Joshua Watt <[email protected]>
@JPEWdev JPEWdev requested review from twoerner and moto-timo March 22, 2024 14:14
@moto-timo
Copy link
Collaborator

moto-timo commented Mar 22, 2024 •
edited
Loading

@jpew thanks for looking into this. The failure about the poetry.lock file reminds me that I would rather use hatch if we are going to use a CLI tool to manage the package.

We could alternatively drop the lock file. I don't think most packages are carrying a lock file these days?

JPEWdev added 3 commits March 22, 2024 08:25
@JPEWdev
Update poetry.lock file
83b1b12 
Poetry demands it

Signed-off-by: Joshua Watt <[email protected]>
@JPEWdev
ci: Change branch to match new name
916e656 
GitHub actions were not running because the branch name was changed from
"master" -> "main"

Signed-off-by: Joshua Watt <[email protected]>
@JPEWdev
ci: Remove black check with poetry
3ce2c51 
We are using a github action for this now

Signed-off-by: Joshua Watt <[email protected]>
@JPEWdev
Copy link
Collaborator Author

JPEWdev commented Mar 22, 2024

@jpew thanks for looking into this. The failure about the poetry.lock file reminds me that I would rather use hatch if we are going to use a CLI tool to manage the package.

Yes, that is next on my TODO list after CI works again

We could alternatively drop the lock file. I don't think most packages are carrying a lock file these days?

Poetry demands it be updated, so I've just done so until Poetry is removed

@moto-timo
Copy link
Collaborator

We could alternatively drop the lock file. I don't think most packages are carrying a lock file these days?

Poetry demands it be updated, so I've just done so until Poetry is removed

And... there is another reason for me to not choose poetry.

moto-timo
moto-timo approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@moto-timo moto-timo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make it so.

@JPEWdev JPEWdev merged commit c460ea6 into yoctoproject:main Mar 22, 2024
4 checks passed
@JPEWdev JPEWdev mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moto-timo moto-timo moto-timo approved these changes

@twoerner twoerner Awaiting requested review from twoerner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JPEWdev @moto-timo