Skip to content

Commit

Permalink
oe-build-perf-report: Add commit hash link to chart tooltip"
Browse files Browse the repository at this point in the history
Signed-off-by: Ninette Adhikari <[email protected]>
  • Loading branch information
ninetteadhikari committed May 22, 2024
1 parent 9416803 commit 1d5e7db
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 13 deletions.
26 changes: 13 additions & 13 deletions scripts/lib/build_perf/html/measurement_chart.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Get raw data
const rawData = [
{% for sample in measurement.samples %}
[{{ sample.commit_num }}, {{ sample.mean.gv_value() }}, {{ sample.start_time }}],
[{{ sample.commit_num }}, {{ sample.mean.gv_value() }}, {{ sample.start_time }}, '{{sample.commit}}'],
{% endfor %}
];

Expand Down Expand Up @@ -30,23 +30,23 @@
const option = {
tooltip: {
trigger: 'axis',
valueFormatter: (value) => {
const commitNumber = rawData.filter(([commit, dataValue, time]) => updateValue(dataValue) === value)
enterable: true,
position: function (point, params, dom, rect, size) {
return [point[0]-150, '10%'];
},
formatter: function (param) {
const value = param[0].value[1]
const sample = rawData.filter(([commit, dataValue]) => updateValue(dataValue) === value)
// Add commit hash to the tooltip as a link
const commitLink = `https://git.yoctoproject.org/poky/commit/?id=${sample[0][3]}`
if ('{{ measurement.value_type.quantity }}' == 'time') {
const hours = Math.floor(value/60)
const minutes = Math.floor(value % 60)
const seconds = Math.floor((value * 60) % 60)
return [
hours + ':' + minutes + ':' + seconds + ', ' +
'commit number: ' + commitNumber[0][0]
]
return `<strong>Duration:</strong> ${hours}:${minutes}:${seconds}, <br/> <strong>Commit number:</strong> <a href="${commitLink}" target="_blank" rel="noreferrer noopener">${sample[0][0]}</a>`
}
return [
value.toFixed(2) + ' MB' + ', ' +
'commit number: ' + commitNumber[0][0]
]
},

return `<strong>Size:</strong> ${value.toFixed(2)} MB, <br/> <strong>Commit number:</strong> <a href="${commitLink}" target="_blank" rel="noreferrer noopener">${sample[0][0]}</a>`
;}
},
xAxis: {
type: 'time',
Expand Down
2 changes: 2 additions & 0 deletions scripts/oe-build-perf-report
Original file line number Diff line number Diff line change
Expand Up @@ -336,10 +336,12 @@ def print_html_report(data, id_comp, buildstats):
test_i = test_data['tests'][test]
meas_i = test_i['measurements'][meas]
commit_num = get_data_item(meta, 'layers.meta.commit_count')
commit = get_data_item(meta, 'layers.meta.commit')
# Add start_time for both test measurement types of sysres and disk usage
start_time = test_i['start_time'][0]
samples.append(measurement_stats(meas_i, '', start_time))
samples[-1]['commit_num'] = commit_num
samples[-1]['commit'] = commit

absdiff = samples[-1]['val_cls'](samples[-1]['mean'] - samples[id_comp]['mean'])
reldiff = absdiff * 100 / samples[id_comp]['mean']
Expand Down

0 comments on commit 1d5e7db

Please sign in to comment.