Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradient zone #62

Merged
merged 5 commits into from
Oct 20, 2024
Merged

Fix gradient zone #62

merged 5 commits into from
Oct 20, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Oct 20, 2024

image

This makes the gradient apply only to the text instead of extending to (probably) the entire page. The values for the gradient can be changed properly.

@jamesmaa
Copy link
Contributor

This makes the gradient apply only to the text instead of extending to (probably) the entire page. The values for the gradient can be changed properly.

How would that happen originally? The css rule was already scoped to the homepage-title id

@Kuuuube
Copy link
Member Author

Kuuuube commented Oct 20, 2024

Well not actually the whole page it looks like but this whole range:
image

That's the area covered by homepage-title. Almost the whole page width.

@jamesmaa
Copy link
Contributor

  • I feel like the p should be homepage-title-wrapper and the span homepage-title.
  • Could we make the p a div?
  • Somehow the bold is no longer there and "Yomitan" looks emaciated, could you fix that?
  • Still unsure about this gradient matching the icon/logo. I don't think it's aesthetically necessary to match. Right now the gradient seems a bit too strong (high contrast) and clashes with the rest of the theme of the website

@Kuuuube
Copy link
Member Author

Kuuuube commented Oct 20, 2024

I feel like the p should be homepage-title-wrapper and the span homepage-title.

Switched

Could we make the p a div?

Sure

Somehow the bold is no longer there and "Yomitan" looks emaciated, could you fix that?

I think this is some difference in my browser or fonts. Even the currently deployed yomitan wiki without these changes doesnt appear bold for me.

Still unsure about this gradient matching the icon/logo. I don't think it's aesthetically necessary to match. Right now the gradient seems a bit too strong (high contrast) and clashes with the rest of the theme of the website

I'm fine to change it to whatever. But it does need to actually apply to the text correctly whichever colors we choose.

@Kuuuube
Copy link
Member Author

Kuuuube commented Oct 20, 2024

Fixed the bold. Now looks like this on both chromium and firefox:
image

@jamesmaa jamesmaa merged commit 7089f87 into yomidevs:master Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants