Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md with instructions on how to load unpackaged build into Chrome #1196

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

BaruYogesh
Copy link

@BaruYogesh BaruYogesh commented Jul 11, 2024

@BaruYogesh BaruYogesh requested a review from a team as a code owner July 11, 2024 03:49
@Kuuuube
Copy link
Member

Kuuuube commented Jul 11, 2024

This looks good but is there any reason you added a height to your image but not a width? I assume adding height is to prevent reflowing which is fine but it distorts the image if you dont also add width.

@BaruYogesh
Copy link
Author

BaruYogesh commented Jul 11, 2024

This looks good but is there any reason you added a height to your image but not a width? I assume adding height is to prevent reflowing which is fine but it distorts the image if you dont also add width.

nope, just wasn't aware. i have updated the dimensions to be half that of the original, otherwise the image is overwhelmingly large.

e: removed img

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Kuuuube Kuuuube added the area/documentation The issue or PR is about documentation label Jul 11, 2024
@Kuuuube Kuuuube changed the title [XS] Update CONTRIBUTING.md with instructions on how to load unpackaged build into Chrome Update CONTRIBUTING.md with instructions on how to load unpackaged build into Chrome Jul 11, 2024
Kuuuube
Kuuuube previously approved these changes Jul 11, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: marv <[email protected]>
Signed-off-by: James Maa <[email protected]>
@jamesmaa jamesmaa enabled auto-merge July 11, 2024 05:26
@jamesmaa jamesmaa added this pull request to the merge queue Jul 11, 2024
Merged via the queue into yomidevs:master with commit 1006c5d Jul 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation The issue or PR is about documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants