Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid collapse leading and trailing emphatics #1227

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Avoid collapse leading and trailing emphatics #1227

merged 4 commits into from
Jul 14, 2024

Conversation

khaitruong922
Copy link

@khaitruong922 khaitruong922 commented Jul 14, 2024 •
edited
Loading

Fixes #1225

  • Do not collapse leading and trailing emphatics of the term, so that searching from an emphatic character will not match the word not starting with it. For example, っ学生 will not match 学生, っぽい will still match っぽい but not ぽい.

@khaitruong922 khaitruong922 requested a review from a team as a code owner July 14, 2024 07:22
@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/linguistics The issue or PR is related to linguistics labels Jul 14, 2024
@Kuuuube Kuuuube added this pull request to the merge queue Jul 14, 2024
Merged via the queue into yomidevs:master with commit ee6185a Jul 14, 2024
10 checks passed
@khaitruong922 khaitruong922 deleted the avoid-emphatic-trim branch July 14, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuuuube Kuuuube Kuuuube approved these changes

@Casheeew Casheeew Casheeew approved these changes

Assignees
No one assigned
Labels
area/linguistics The issue or PR is related to linguistics kind/bug The issue or PR is regarding a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searching from emphatic characters should not match next word
3 participants
@khaitruong922 @Casheeew @Kuuuube