Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redid the Action Popup #1525

Merged
merged 11 commits into from
Nov 25, 2024
Merged

Redid the Action Popup #1525

merged 11 commits into from
Nov 25, 2024

Conversation

martholomew
Copy link

1729816379
1729816372
1729816363
1729816358
1729816340
1729816334
1729816325
1729816314

  1. Changed the layout in favor of a more modern, material layout.
  2. Added a dynamic tooltip indicating how to scan.
  3. Redid some logic in the On/Off switch so that it updates when profiles are switched (there remains an edge case when the settings page is focused where it exhibits strange behavior).

@martholomew martholomew requested a review from a team as a code owner October 25, 2024 00:37
jamesmaa
jamesmaa reviewed Oct 25, 2024
View reviewed changes
ext/js/pages/action-popup-main.js Show resolved Hide resolved
ext/js/pages/action-popup-main.js Outdated Show resolved Hide resolved
ext/action-popup.html Show resolved Hide resolved
ext/images/info.svg Outdated Show resolved Hide resolved
ext/action-popup.html Outdated Show resolved Hide resolved
ext/css/action-popup.css Outdated Show resolved Hide resolved
ext/action-popup.html Outdated Show resolved Hide resolved
ext/action-popup.html Outdated Show resolved Hide resolved
@Kuuuube
Copy link
Member

Kuuuube commented Oct 25, 2024

Does this take into account the mobile version of the popup? It looks like youve just ripped out all of that.

@MarvNC
Copy link
Member

MarvNC commented Oct 25, 2024

I like the colors you went with, with the gradient showing only when it's on.
Also CI is failing, do you have your local env set up correctly?

@koiyakiya
Copy link

image
Btw this might be confusing im not sure

@Kuuuube
Copy link
Member

Kuuuube commented Oct 25, 2024

Theres a function somewhere that sets that text for the correct OS since it's always different. Can just borrow that.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Nov 6, 2024
@martholomew
Copy link
Author

Screenshot_20241121_225458
Screenshot_20241121_225344
1732255101
1732255031
1732254925
1732254919
Screenshots of Firefox mobile and Chrome

@Kuuuube Kuuuube mentioned this pull request Nov 23, 2024
Closed
@jamesmaa jamesmaa added this pull request to the merge queue Nov 25, 2024
Merged via the queue into yomidevs:master with commit a9d949f Nov 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuuuube Kuuuube Kuuuube left review comments

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martholomew @Kuuuube @MarvNC @koiyakiya @jamesmaa