Reapply "Support default setting overrides on different languages (#1… #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playwright test results
Details
|
jamesmaa
force-pushed
the
redo-recommended-settings
branch
3 times, most recently
from
922cfdd to
d42bc97
Compare
Kuuuube
previously approved these changes
Oct 28, 2024
…midevs#1368)" (yomidevs#1530) This reverts commit 019c458.
jamesmaa
force-pushed
the
redo-recommended-settings
branch
from
aad961a to
fb9a908
Compare
jamesmaa
force-pushed
the
redo-recommended-settings
branch
from
b744869 to
4d2811f
Compare
|
Cool this PR is no longer causing flakiness in the playwright tests anymore. Please review 🙏 |
Kuuuube
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…368)" (#1530)
This reverts commit 019c458.