Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force scan resolution "character" for ja, zh, yue, and ko #1542

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Oct 28, 2024

Also hides the option from settings for these languages and splits out the visibility modifiers.

Addresses #1368 (review)

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Oct 28, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner October 28, 2024 21:13
@jamesmaa
Copy link
Collaborator

Wouldn't this be better enforced by enforcing jazhyueko to have the scanResolution setting to be character?

@Kuuuube
Copy link
Member Author

Kuuuube commented Oct 28, 2024

As in setting the variable to that in the text scanner when options are passed through? That would be fine. Actually changing the setting set by the user I'd rather not do that though.

Copy link

github-actions bot commented Oct 28, 2024

Playwright test results

failed  1 failed
passed  3 passed
flaky  1 flaky

Details

stats  5 tests across 4 suites
duration  5 minutes, 49 seconds
commit  3ad6191

Failed tests

chromium › visual.spec.js › visual

Flaky tests

chromium › integration.spec.js › anki add

@MarvNC
Copy link
Member

MarvNC commented Oct 28, 2024

Actually changing the setting set by the user I'd rather not do that though.

Why? For those languages it makes sense, and it seems like it'd be easier to maintain than having to find a const in text-scanner.

@Kuuuube
Copy link
Member Author

Kuuuube commented Oct 28, 2024

Just feels wrong. The user changed one setting (language) and it automatically changed a setting they didnt intend to change.

jamesmaa
jamesmaa previously approved these changes Nov 4, 2024
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this solution should be more generalizable but I haven't come up with future use cases just yet so i don't think it's worth having an inferior user experience while waiting for said generalized solution.

@jamesmaa jamesmaa added this pull request to the merge queue Nov 5, 2024
Merged via the queue into yomidevs:master with commit 3ad6191 Nov 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants