-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force scan resolution "character" for ja, zh, yue, and ko #1542
Conversation
Wouldn't this be better enforced by enforcing jazhyueko to have the |
As in setting the variable to that in the text scanner when options are passed through? That would be fine. Actually changing the setting set by the user I'd rather not do that though. |
Why? For those languages it makes sense, and it seems like it'd be easier to maintain than having to find a const in text-scanner. |
Just feels wrong. The user changed one setting (language) and it automatically changed a setting they didnt intend to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this solution should be more generalizable but I haven't come up with future use cases just yet so i don't think it's worth having an inferior user experience while waiting for said generalized solution.
Signed-off-by: Kuuuube <[email protected]>
Also hides the option from settings for these languages and splits out the visibility modifiers.
Addresses #1368 (review)