Allow queueing dictionary update & delete together #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaitruong922
commented
Nov 4, 2024
Comment on lines
1231
to
1234
| /** @type {Promise<void>} */ | ||
| const importPromise = new Promise((resolve) => { | ||
| this._settingsController.trigger('importDictionaryFromUrl', {url: downloadUrl, profilesDictionarySettings, onImportDone: resolve}); | ||
| }) |
There was a problem hiding this comment.
I don't think this is the correct way to do this but this is the only way I can think of to await an event trigger.
khaitruong922
changed the title
|
Ready for review. |
khaitruong922
changed the title
khaitruong922
force-pushed
the
update-queue
branch
from
6579cba to
4222e7b
Compare
jamesmaa
previously approved these changes
Nov 5, 2024
Kuuuube
added
kind/enhancement
Playwright test results
Details
Failed testschromium › visual.spec.js › visual |
|
Now will persist the update button with the same link even if the dictionary list is rerendered. |
Kuuuube
approved these changes
Nov 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1557
When enqueue a dictionary, hide its update button.Also refactor dictionary update and delete behavior, only allow 1 queue to run at a time.- If update queue is running then disable all delete buttons.- If delete queue is running then hide all update buttons.