-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Yiddish support to Yomitan #1567
base: master
Are you sure you want to change the base?
Add Yiddish support to Yomitan #1567
Conversation
This is the dictionary we would use to test. Generated with kty with entries provided with "nikkudes"-less versions after. |
What's the status of this PR? I haven't reviewed it since it's still in draft |
It works but I wanted to run it against a Yiddish speaker or a linguist first |
I can make a call out to the Yiddish subreddit for review if you need help finding folks. |
Feel free. @capt-v and I just went through and added a few missing plural forms. I'm contemplating a few more changes though, tbh. I wonder if removing ende letters in the preprocessor and just assuming there is no ende letters at all would be better, since it would mean the same transforms should work better on Soviet (which removes ende letters) orthography. Soviet orthography is very rare but if a relatively small change adds that much more, it shouldn't be a terrible idea. Wondering also if I'm overcomplicating all of this. |
…lef and komets alef, and demutation of vov yud to ayin
Honestly I would be fine with minimal review with this PR. As we get more Yiddish users we can follow up with future fixes and more coverage with the conjugation. |
Should I then make it not a draft? |
If you feel like it's shippable and you're not going to improve it in the near future, then yeah |
This pull request adds support for Yiddish.
It is not perfect, and more/better transforms could be added, but I believe this is sufficient for now. The preprocessor strips nikudes so the dictionary would need to as well to prevent matching issues. However, the postprocessor makes sure ligatures are not an issue,
My code is a bit ugly, I have never worked with TypeScript so if anyone can suggest some ways to make it nicer, that would be greatly appreciated. Thank you!