Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort & collapse kanji dictionary entries #1581

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Sort & collapse kanji dictionary entries #1581

merged 6 commits into from
Nov 19, 2024

Conversation

khaitruong922
Copy link

@khaitruong922 khaitruong922 commented Nov 8, 2024 •
edited by MarvNC
Loading

Fixes #953
Resolves #1589

@khaitruong922 khaitruong922 requested a review from a team as a code owner November 8, 2024 14:09
@khaitruong922 khaitruong922 changed the title Sort kanji entries by index and priority Sort & collapse kanji dictionary entries Nov 8, 2024
@khaitruong922 khaitruong922 marked this pull request as draft November 8, 2024 14:22
@khaitruong922
Copy link
Author

Screenshot
image
image

Current state of kanji dictionary collapse:

  • Collapse button does not display fully on small width
    image
  • Collapsible max height may not be calculated correctly.
  • Does not work correctly on Collapsible mode (only works when screen width is decreased then increased again)

@khaitruong922 khaitruong922 mentioned this pull request Nov 15, 2024
Closed
@khaitruong922 khaitruong922 marked this pull request as ready for review November 15, 2024 03:40
@khaitruong922
Copy link
Author

ready for review

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

Playwright test results

passed  5 passed

Details

stats  5 tests across 4 suites
duration  1 minute, 37 seconds
commit  746bed5

MarvNC
MarvNC requested changes Nov 19, 2024
View reviewed changes
ext/js/language/translator.js Outdated Show resolved Hide resolved
@MarvNC MarvNC added this pull request to the merge queue Nov 19, 2024
Merged via the queue into yomidevs:master with commit fd97f0b Nov 19, 2024
12 checks passed
@MarvNC MarvNC added kind/bug The issue or PR is regarding a bug area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request and removed kind/bug The issue or PR is regarding a bug labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvNC MarvNC MarvNC approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dictionary ordering seems very unintuitive Ordering Kanji Dictionaries & Collapse doesn't work
2 participants
@khaitruong922 @MarvNC