Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dictionary priority from settings #1606

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Remove dictionary priority from settings #1606

merged 4 commits into from
Nov 26, 2024
+1,354 −3,498

Conversation

khaitruong922
Copy link

Closes #1603

@khaitruong922 khaitruong922 requested a review from a team as a code owner November 26, 2024 16:03
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 26, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1606 will not alter performance

Comparing khaitruong922:remove-priority (5024651) with master (49be0db)

Summary

✅ 3 untouched benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Playwright test results

passed  5 passed

Details

stats  5 tests across 4 suites
duration  1 minute, 39 seconds
commit  49be0db

Kuuuube
Kuuuube approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested the update sorting and it works great.

@Kuuuube Kuuuube added this pull request to the merge queue Nov 26, 2024
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Nov 26, 2024
Merged via the queue into yomidevs:master with commit caae952 Nov 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuuuube Kuuuube Kuuuube approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dictionary priority from settings
2 participants
@khaitruong922 @Kuuuube