Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spacing and moved tabindex in the action popup #1619

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fixed spacing and moved tabindex in the action popup #1619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14c5ce2
fix spacing issues
martholomew Nov 27, 2024
1fb33a7
move tabindex
martholomew Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/action-popup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
Loading...
</div>
<div id="action-popup">
<div tabindex="0" class="action-container action-select-profile" hidden>
<div class="action-container action-select-profile" hidden>
<div class="action-item-left">
<h2 class="action-title">Profile</h2>
</div>
<div class="action-item-right">
<select class="profile-select" id="profile-select">
<select tabindex="0" class="profile-select" id="profile-select">
</select>
</div>
</div>
Expand Down
38 changes: 20 additions & 18 deletions ext/css/action-popup.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,24 +197,6 @@ input[type=checkbox]~.toggle-group>.toggle-handle:active:focus {
box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.125);
}

/* Actions */

.action-select-profile {
position: relative;
}

select.profile-select {
width: 7em;
height: 100%;
box-sizing: border-box;
border: 0;
margin: 0;
cursor: pointer;
font-size: var(--font-size);
overflow: hidden;
text-overflow: ellipsis;
}

/* Action Containers */

h2.action-title {
Expand Down Expand Up @@ -273,12 +255,32 @@ h2.action-title {
justify-content: space-between;
align-items: center;
padding: 10px;
gap: 0.25em;
}

.action-container button {
flex: 0 0 auto;
}

/* Actions */

.action-container.action-select-profile {
position: relative;
gap: 0.5em;
}

select.profile-select {
width: 7em;
height: 100%;
box-sizing: border-box;
border: 0;
margin: 0;
cursor: pointer;
font-size: var(--font-size);
overflow: hidden;
text-overflow: ellipsis;
}

/* Tooltip */

.tooltip {
Expand Down