Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotations and visibility classes to some Japanese-specific settings #1659

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Add annotations and visibility classes to some Japanese-specific settings #1659

merged 3 commits into from
Dec 12, 2024

Conversation

impucky
Copy link

@impucky impucky commented Dec 12, 2024

Fixes #1612

Changes:

  • Added a jp-only visibility class
  • Term display style: added the jpzhyue-only class
  • Reading mode: added the "Japanese only" annotation and jp-only class
  • Pitch accent display: added the "Japanese only" annotation, but not the visibility class (so other languages potentially using pitch dictionaries don't lose the setting?)
  • MeCab: added the "Japanese only" annotation and jp-only class

I've kept the visibility stuff in separate commits if it's too much for the scope of this issue.

@impucky impucky requested a review from a team as a code owner December 12, 2024 20:37
@github-actions GitHub Actions
Copy link

Playwright test results

failed  1 failed
passed  4 passed

Details

stats  5 tests across 4 suites
duration  4 minutes, 39 seconds
commit  955ff45

Failed tests

chromium › visual.spec.js › visual

@jamesmaa jamesmaa added this pull request to the merge queue Dec 12, 2024
Merged via the queue into yomidevs:master with commit 0aa05e2 Dec 12, 2024
12 checks passed
@impucky impucky deleted the 1612-jp-settings-annotations branch December 12, 2024 23:14
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotate "Japanese Only" in "Pitch accent display styles" setting
3 participants
@impucky @jamesmaa @Kuuuube