-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add French de-inflection #1668
Add French de-inflection #1668
Conversation
Signed-off-by: Salwynn <[email protected]>
Signed-off-by: Salwynn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to merge as is. We don't currently have many French users but if they run into any issues they can report them to us. Would it be easy to add TODO's to all the missing coverage of grammar or is that too much work? With a file size this large it might better organized that way
Yeah that shouldn't be too bad, I'll try to get that in later today. |
CodSpeed Performance ReportMerging #1668 will degrade performances by 32.65%Comparing Summary
Benchmarks breakdown
|
Follow-up to Salwynn's work in #1626
Resolves #1572
I haven't tested the rules thoroughly but I fixed everything I could notice in the transforms.
Let me know if I've overlooked anything.