Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French de-inflection #1668

Merged
merged 9 commits into from
Dec 16, 2024
Merged

Add French de-inflection #1668

merged 9 commits into from
Dec 16, 2024

Conversation

impucky
Copy link

@impucky impucky commented Dec 15, 2024

Follow-up to Salwynn's work in #1626
Resolves #1572

I haven't tested the rules thoroughly but I fixed everything I could notice in the transforms.
Let me know if I've overlooked anything.

@impucky impucky requested a review from a team as a code owner December 15, 2024 23:32
Copy link

github-actions bot commented Dec 15, 2024

Playwright test results

failed  2 failed
passed  3 passed

Details

stats  5 tests across 4 suites
duration  8 minutes, 32 seconds
commit  68a5979

Failed tests

chromium › integration.spec.js › anki add
chromium › visual.spec.js › visual

jamesmaa
jamesmaa previously approved these changes Dec 16, 2024
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to merge as is. We don't currently have many French users but if they run into any issues they can report them to us. Would it be easy to add TODO's to all the missing coverage of grammar or is that too much work? With a file size this large it might better organized that way

@impucky
Copy link
Author

impucky commented Dec 16, 2024

Yeah that shouldn't be too bad, I'll try to get that in later today.

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #1668 will degrade performances by 32.65%

Comparing impucky:fr-deinflection (d92a02b) with master (daccc9f)

Summary

❌ 1 (👁 1) regressions
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark master impucky:fr-deinflection Change
👁 Translator.prototype.findKanji - (n=3) 2.7 ms 3.9 ms -32.65%

@jamesmaa jamesmaa added this pull request to the merge queue Dec 16, 2024
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Dec 16, 2024
Merged via the queue into yomidevs:master with commit 68a5979 Dec 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[French]: French de-inflection logic
4 participants