Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constant error on firefox mobile from chrome.contextMenus #1675

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Dec 17, 2024

Fixes #1674

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug browser/firefox The issue is Firefox-only platform/android-only The issue is android only labels Dec 17, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner December 17, 2024 13:42
Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #1675 will improve performances by 25.58%

Comparing Kuuuube:fix-contextmenus-error (812fd19) with master (f3dff02)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark master Kuuuube:fix-contextmenus-error Change
japanese transformations-full (n=212) 60.9 ms 48.5 ms +25.58%

Copy link

Playwright test results

failed  2 failed
passed  3 passed

Details

stats  5 tests across 4 suites
duration  8 minutes, 33 seconds
commit  f3dff02

Failed tests

chromium › integration.spec.js › anki add
chromium › visual.spec.js › visual

@Casheeew Casheeew added this pull request to the merge queue Dec 17, 2024
Merged via the queue into yomidevs:master with commit f23c870 Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser/firefox The issue is Firefox-only kind/bug The issue or PR is regarding a bug platform/android-only The issue is android only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yomitan Errors on Firefox Mobile
2 participants