Fix bad performance.mark names causing performance.measure to fail #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/bug
CodSpeed Performance ReportMerging #1676 will improve performances by 24.92%Comparing Summary
Benchmarks breakdown
|
Playwright test results
Details
Failed testschromium › visual.spec.js › visual |
Casheeew
approved these changes
Dec 17, 2024
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression added in #1670
Causes the popup to not render any contents.
Considering
performance.markis not linted or checked in our code (if possible that would be nice to have) maybe we need to make wrapper functions for this to handle errors without blowing up the entire extension.