Add chrome dev crx to releases #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
the
area/ci
jamesmaa
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium can already install extensions from zip files offline without issue but updating extensions installed that way is essentially impossible. With a consistently signed crx it is possible for users to both install and update the extension without using the store.
We can't sign the crx with the same key as google does on the store so users wont be able to update their extension with this crx file if they previously downloaded from the store. Only the store can update the store version and only the release crx will be able to update the release crx.
It also isn't reasonable to make an action that downloads the chrome store crx and uploads that since there's no way to know when the chrome store will be updated and allow downloading the new version.
This will require adding a new secret named
CHROME_CRX_PRIVATE_KEY. How to generate this key is noted here: https://github.com/cardinalby/webext-buildtools-chrome-crx-action?tab=readme-ov-file#-privatekey-required.