Fix image render area #1696
Merged
Fix image render area #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/bug
|
Anki seems to not support something with the styling here. Will have to look into that further. |
|
This should be good to go. Anki stuff is working properly now. |
jamesmaa
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1694
Prevents the canvas image from being rendered with the size defined in the dictionary. This size often does not match the size of the image and effectively crops out parts of the image that are not in the bounds rather than scaling to those bounds. Images that are smaller than the size defined in the dictionary are cropped bigger instead of resizing causing extra empty padding to be added to the image.
Instead of the canvas handling the scaling,
imageContainershould do it.Would like comment from @djahandarie as I'm not entirely sure if the part I've removed in be22e85 was a hacky workaround due to not scaling the canvas properly or if there's another purpose for it. In my testing I haven't noticed any issues with image scaling or rendering from this with dictionaries that use
emforsizeUnitsafter this change.Tested on Chromium and Firefox.