Fix svg styling and image scaling #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/bug
jamesmaa
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the styling issues with svgs displaying wrong (mostly reverting incorrectly removed code from #1487). This doesn't entirely fix the styling since there are some differences between canvases and images that need entirely new css. For example the numbering svgs in
三省堂国語辞典 第八版are still kindof inverted and weird color.Fixes image scaling causing very low quality and grainy images. Scaling a canvas is apparently a horrible thing to do and causes lots of trouble (and attempting to fix this directly has many inconsistencies across browsers) so it is best if the images displayed within them are resized beforehand (851280f).