Fix uncollapse link and clicking on images

[Kuuuube]

Fixes #1704

Adds back the collapsed image [Image] text and opens the original image in a new tab when clicked on. Opening the original image is important since the canvas can be scaled different (often smaller) and is less useful to open to see in a new tab.

content-visibility: auto; cuts off the preview thumbnail display for collapsed images if it is at the bottom of an entry.

openMediaInTab is similar to the old _getMediaData

yomitan/ext/js/display/display-content-manager.js

Lines 140 to 150 in 76ca08b

	async _getMediaData(path, dictionary) {
	const token = this._token;
	const datas = await this._display.application.api.getMedia([{path, dictionary}]);
	if (token === this._token && datas.length > 0) {
	const data = datas[0];
	const buffer = base64ToArrayBuffer(data.content);
	const blob = new Blob([buffer], {type: data.mediaType});
	const url = URL.createObjectURL(blob);
	return {data, url};
	}
	return null;

Double check on this._contentManager instanceof DisplayContentManager because typescript has the memory of a goldfish and forgets that it was checked in the previous if statement.

[codspeed-hq]

CodSpeed Performance Report

Merging #1705 will not alter performance

_{Comparing Kuuuube:fix-uncollapse-link (112a429) with master (58ecbeb)}

Summary

✅ 3 untouched benchmarks

[github-actions]

Playwright test results

 5 passed

Details

 5 tests across 4 suites
 1 minute, 34 seconds
 7d4ae00

[djahandarie]

Double check on this._contentManager instanceof DisplayContentManager because typescript has the memory of a goldfish and forgets that it was checked in the previous if statement.

(You may already know this but) it's actually correct, because in theory the contents of this._contentManager could change between when the event listener is added and when it triggers. We know that it won't because we clear the elements and their event listeners when we switch the popup contents / the content manager, but there is no guarantee of it, and indeed one could imagine a bug being introduced at some point that causes that invariant to not be true since there is no type safety regarding ordering of stuff like this.

[djahandarie]

BTW, removing content-visibility:auto introduces a fairly significant performance degradation (maybe 5x slowly popup render time for a big popup). I'll try to think if there's someway to restore it without causing a bug here.