Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG filter matrix to color monochrome images #1707

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Dec 27, 2024

This gets all the colors to be exactly what they were previously but this might not be desirable due to how thin lines in the svgs look right now.

Before canvas Current master After this pr
398849797-0f7a3d81-eeda-4722-9efe-8dd971caf9a9 398973107-2ae01d95-fe9b-4953-b562-cfc967e08ecb chrome-extension___iddnegfgfaleoehdfpeamimafiiohlki_search html_query=%E5%88%87%E3%82%8C type=terms wildcards=off

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Dec 27, 2024
Copy link

github-actions bot commented Dec 27, 2024

Playwright test results

passed  4 passed
flaky  1 flaky

Details

stats  5 tests across 4 suites
duration  2 minutes, 37 seconds
commit  4b97a01

Flaky tests

chromium › integration.spec.js › anki add

@djahandarie
Copy link
Collaborator

My guess is that this won't perform anywhere as near as well as the filter either, though not sure, would require testing.

Copy link

codspeed-hq bot commented Dec 28, 2024

CodSpeed Performance Report

Merging #1707 will improve performances by 23.12%

Comparing Kuuuube:svg-filter (25c7a46) with master (4b97a01)

Summary

⚡ 1 improvements
✅ 4 untouched benchmarks

Benchmarks breakdown

Benchmark master Kuuuube:svg-filter Change
spanish transformations (n=97) 15 ms 12.2 ms +23.12%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants