Add actionlint & fix detected issues #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djahandarie
added
kind/meta
djahandarie
force-pushed
the
actionlint
branch
from
681d9de to
960df67
Compare
Kuuuube
approved these changes
Dec 28, 2024
MarvNC
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub actions workflows are incredibly dangerous from a security perspective, and in particular it's really easy to write vulnerable bash scripts in them.
actionlintchecks a number of things (including running shellcheck on allrunscripts within the workflows). This will hopefully be a good start to securing our workflows a bit more.