Speed up playwright (pt2: full parallelization) #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djahandarie
force-pushed
the
parallelize-playwright
branch
6 times, most recently
from
a39cfc4 to
074f569
Compare
djahandarie
force-pushed
the
parallelize-playwright
branch
from
074f569 to
1c8a431
Compare
djahandarie
changed the title
djahandarie
added
kind/meta
jamesmaa
approved these changes
Dec 31, 2024
This was referenced Jan 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tuning
We have a quota of 20 total concurrent jobs, so we could potentially increase the number of shards introduces by this PR (5) but it may come at the cost of causing other jobs to get queued since we have no way of specifying priority between jobs, which may not be the right tradeoff. Also, separately, we could increase the number of workers in playwright from 1 to 2, but will need to observe the stability within GitHub actions runners. It would be appropriate to tune further.
Reason for changes in the screenshots
Previously, since we were using a single browser, one of the tests (test 6) was never able to clear its popup from the screen properly, and lingered in the results of all the following tests (7 to 16). Now since each test is isolated, the ghost of test 6 will no longer be present, which you can see in the diffs.