Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More minor playwright performance improvements #1734

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

djahandarie
Copy link
Collaborator

@djahandarie djahandarie commented Jan 1, 2025

A few more minor playwright performance improvements:

  • Reduce the viewport size on popup screenshots so they execute faster (and it also makes the results easier to read)
  • Split the two big dictionary loads into separate tests so they can be executed in parallel

This is expected to change playwright results since the viewport size is different, and also the number of remaining dictionaries after the swedish delete is different (0 instead of 1)

@djahandarie djahandarie added kind/meta The issue or PR is meta area/ci The issue or PR is related to continuous integration and/or continuous delivery labels Jan 1, 2025
@djahandarie djahandarie requested a review from a team as a code owner January 1, 2025 06:39
@Casheeew Casheeew added this pull request to the merge queue Jan 1, 2025
Merged via the queue into master with commit 389a583 Jan 1, 2025
26 checks passed
@Casheeew Casheeew deleted the more-playwright-performance branch January 1, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci The issue or PR is related to continuous integration and/or continuous delivery kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants