Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown Formatting #270

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Conversation

MarvNC
Copy link
Member

@MarvNC MarvNC commented Oct 5, 2023

Makes the markdown formatting much more consistent by using the Markdown All in One extension.

@MarvNC MarvNC requested a review from a team as a code owner October 5, 2023 20:20
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@djahandarie
Copy link
Collaborator

@MarvNC I think it's kinda hard to manage vscode settings.json in git. It'd be better if we could keep it in another location (like settings-upstream.json) to avoid conflicting with people's existing settings but I don't think vscode supports reading from other files. So I think we should remove it for the moment 🤔

@MarvNC
Copy link
Member Author

MarvNC commented Oct 22, 2023

Related discussion

I wouldn't think it's a common use case for people to have per-project settings that aren't already upstream, though naming it settings.json.default as suggested in one comment could work. However, with that approach the user would need to manually look out for changes in the settings.json and would be likely to miss out on any potential changes otherwise.

Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I guess we can try experimenting with having .vscode/settings.json checked in.

@djahandarie djahandarie added this pull request to the merge queue Oct 22, 2023
Merged via the queue into yomidevs:master with commit 7039438 Oct 22, 2023
6 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Oct 24, 2023
@MarvNC MarvNC deleted the add-markdown-formatting branch October 27, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants