Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handlebars import for media provider, pw env file #311

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

jbukl
Copy link

@jbukl jbukl commented Nov 9, 2023

adding of cards with {clipboard-text} and {audio} were failing - handlebars import in one file wasn't converted for the move to esm

  • fix handlebars import media provider for templates
  • remove globals comments from files (though none of the others were missing anything)
  • add .env file because it was annoying me to run playwright locally since I had to explicitly export the SW flag for CLI usage (and centralizes the env stuff instead of having it lingering in multiple places) - let me know if not wanted

@jbukl jbukl requested a review from a team as a code owner November 9, 2023 16:08
Copy link

github-actions bot commented Nov 9, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@djahandarie djahandarie merged commit 2cd7b14 into yomidevs:playwright-esm Nov 9, 2023
3 checks passed
@djahandarie
Copy link
Collaborator

Oh, could you open a PR for the master branch?

@djahandarie
Copy link
Collaborator

Err, nevermind, I see mine was still unmerged, I get it now 😃

@djahandarie djahandarie added the kind/meta The issue or PR is meta label Nov 10, 2023
@jbukl jbukl deleted the pw-esm-fix branch November 10, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants