Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing word in comment #405

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix missing word in comment #405

merged 1 commit into from
Dec 20, 2023

Conversation

Casheeew
Copy link
Member

No description provided.

@Casheeew Casheeew requested a review from a team as a code owner December 20, 2023 01:28
@github-actions GitHub Actions
Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@Casheeew
Copy link
Member Author

(_normalizeTermOrReading is currently a no-op, why wasn't it just removed instead?)

@toasted-nutbread
Copy link

(_normalizeTermOrReading is currently a no-op, why wasn't it just removed instead?)

Because realistically, normalization prior to importing could save a lot of processing later on during the lookup process, if implemented intelligently and carefully. For example, converting half width characters to their normal counterparts, converting full width to regular characters, etc. During the lookup process, there is a giant set of variants that is constructed to work around this issue. Therefore, I left the placeholder in there in case I, or someone else, eventually got back to that.

@djahandarie djahandarie added this pull request to the merge queue Dec 20, 2023
Merged via the queue into yomidevs:master with commit fa2fbfa Dec 20, 2023
5 checks passed
@Casheeew Casheeew deleted the fix-typo branch December 20, 2023 05:49
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toasted-nutbread toasted-nutbread toasted-nutbread approved these changes

@djahandarie djahandarie djahandarie approved these changes

Assignees
No one assigned
Labels
kind/meta The issue or PR is meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Casheeew @toasted-nutbread @djahandarie