Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style updates #447

Merged
merged 6 commits into from
Dec 25, 2023
Merged

Style updates #447

merged 6 commits into from
Dec 25, 2023

Conversation

Casheeew
Copy link
Member

No description provided.

@Casheeew Casheeew requested a review from a team as a code owner December 25, 2023 02:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2023 •
edited
Loading

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

djahandarie
djahandarie requested changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

de/lib/handlebars is just a vendored copy of kbn's handlebars so we probably shouldn't make changes here. Rest looks fine

@Casheeew
Copy link
Member Author

I left changes to comments from yomitan developers, such as "liftet from handlebars/..." -> "Lifted from handlebars/..."

@Casheeew Casheeew requested a review from djahandarie December 25, 2023 04:18
@djahandarie
Copy link
Collaborator

Those aren't our comments, they are kbn's comments for the stuff they lifted from handlebars proper.

@Casheeew
Copy link
Member Author

Oh, I didn't realize that, sorry.

@Casheeew
Copy link
Member Author

It should be fine now after a squash and merge

@djahandarie djahandarie added this pull request to the merge queue Dec 25, 2023
Merged via the queue into yomidevs:master with commit 8e95d99 Dec 25, 2023
5 checks passed
@Casheeew Casheeew deleted the dev4 branch December 25, 2023 12:46
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djahandarie djahandarie djahandarie approved these changes

Assignees
No one assigned
Labels
kind/meta The issue or PR is meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Casheeew @djahandarie