Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text-shadow style in dictionary structured content #527

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Allow text-shadow style in dictionary structured content #527

merged 1 commit into from
Jan 15, 2024

Conversation

stephenmk
Copy link

This style can be used to improve the contrast and legibility of text in some circumstances.

stephenmk/Jitendex#52 (comment)

@stephenmk stephenmk requested a review from a team as a code owner January 15, 2024 06:26
Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Though why does this work like this at all...? Wouldn't it make more sense for a dictionary to distribute some CSS (maybe with basic filtering to avoid remote resources) and then just refer to class names in the structured content...?)

@djahandarie djahandarie added this pull request to the merge queue Jan 15, 2024
Merged via the queue into yomidevs:master with commit 9cfa20c Jan 15, 2024
5 checks passed
@djahandarie djahandarie added the kind/enhancement The issue or PR is a new feature or request label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants