Replace text-decoration
with bottom-border
in links with ruby text
#595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an annoying bug in WebKit that causes the text decoration line to split when the link contains ruby text that is wider than the base ruby character. See the link to "慎重" in the image below to see what I mean. The line underneath 重 is not wide enough.
(This bug doesn't affect Firefox.)
I propose replacing the text decoration line with a bottom-border when a hyperlink contains ruby text. You might ask why we should limit it to only the links that contain ruby text. If we use a bottom border style all the time, then the external hyperlink icons (visible in the lower right corner) will also be underlined.
I also suggest adding a small amount of padding (
text-underline-offset
) to all hyperlinks. This is the same amount of padding (0.2rem
) that GitHub uses in its hyperlink styles. It can help prevent 十 from looking like 士, for example.Here's an image of the same entry with my proposed new styles.