Move sandbox files #731
Merged
Move sandbox files #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
CodSpeed Performance ReportMerging #731 will degrade performances by 32.12%Comparing Summary
Benchmarks breakdown
|
djahandarie
previously approved these changes
Mar 3, 2024
toasted-nutbread
force-pushed
the
sandbox-file-simplification
branch
from
3e0ae1e to
40430a9
Compare
djahandarie
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been some question about this before, but the sandbox folders are a legacy setup from before type annotations were used. It was used to denote specific files that were used in different environments (workers, service worker, no extension APIs), but this is now enforced by eslint-config.test.js. Worth simplifying so people don't have to think about this anymore.