Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci updates #757

Merged
merged 4 commits into from
Mar 3, 2024
Merged

Ci updates #757

merged 4 commits into from
Mar 3, 2024

Conversation

toasted-nutbread
Copy link

@toasted-nutbread toasted-nutbread commented Mar 2, 2024

Resolves ##733 (comment).

Fixes an issue with the test data writing where it was missing an extra newline.

The standalone vitest config files were updated because it seems that the previous wildcard was being used relative to the root directory. So running npm run test:unit:options could actually end up invoking stuff outside of the project directory:

 ✓ ../yomitan-new/test/options-util.test.js (3)
 ✓ ../yomitan-old/test/options-util.test.js (3)
 ✓ ../yomichan/test/options-util.test.js (3)
 ✓ test/options-util.test.js (20)

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner March 2, 2024 16:39
Copy link

github-actions bot commented Mar 2, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@Casheeew Casheeew added the kind/meta The issue or PR is meta label Mar 2, 2024
@djahandarie djahandarie added this pull request to the merge queue Mar 3, 2024
Merged via the queue into yomidevs:master with commit df7acf3 Mar 3, 2024
10 checks passed
@Casheeew Casheeew added the area/ci The issue or PR is related to continuous integration and/or continuous delivery label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci The issue or PR is related to continuous integration and/or continuous delivery kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants