Add Margin to Search Page #781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
|
Actually it seems there's no horizontal padding there on purpose? Personally I think it should be changed. |
MarvNC
force-pushed
the
add-search-page-margin
branch
from
b549281 to
7681131
Compare
StefanVukovic99
added
kind/enhancement
MarvNC
force-pushed
the
add-search-page-margin
branch
from
0c66466 to
3b4ab1b
Compare
|
Can you add more context in the PR description on why you're proposing this change? |
|
Okay, done. Needs repro though as @StefanVukovic99 said they weren't able to repro. |
|
I can reproduce the issue. |
Kuuuube
added
kind/bug
|
Also this is a fix from a regression added after 24.01.14.0 not an enhancement. Changed the tags around. |
|
Not able to replicate the issue being fixed by this pr. Opened #839 which fixes the issue in my testing. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done because the search page looks really bad imo without the margins if viewed in a low width window (it's hard to get across in the GitHub image).