improve modal and tests #366

	name: "Ruby on Rails CI"
	on:
	push:
	branches: [ "*" ]
	jobs:
	build_and_run_tests:
	name: Build and run tests
	runs-on: ubuntu-latest
	services:
	mysql:
	image: mysql
	ports:
	- 3306:3306
	env:
	MYSQL_ROOT_PASSWORD: mysql
	MYSQL_DATABASE: test
	MYSQL_USER: test
	MYSQL_PASSWORD: test
	# Set health checks to wait until mysql has started
	options: >-
	--health-cmd "mysqladmin ping -h 127.0.0.1 -u root -p$$MYSQL_ROOT_PASSWORD"
	--health-interval 10s
	--health-timeout 5s
	--health-retries 5
	steps:
	- name: Checkout code
	uses: actions/checkout@v4
	- name: Install Ruby and gems
	uses: ruby/setup-ruby@v1
	with:
	bundler-cache: true
	- name: Run tests with sqlite3
	env:
	RAILS_ENV: test
	DATABASE_URL: sqlite3:db/test.sqlite3
	run: \|
	bundle exec rails db:reset
	bundle exec rails db:seed
	bundle exec rails test -v
	bundle exec rails test:system TESTOPTS="-v"

	- name: Run tests with mysql
	env:
	RAILS_ENV: test
	DATABASE_URL: mysql2://test:[email protected]:3306/test
	run: \|
	bundle exec rails db:reset
	bundle exec rails db:seed
	bundle exec rails test -v
	bundle exec rails test:system TESTOPTS="-v"

	- name: Create tar archive of screenshots
	run: \|
	( cd /home/runner/work/etd/etd/tmp && [ -d ./test-screenshots ] && tar cvf test-screenshots.tar ./test-screenshots ) \|\| true

	- name: Upload screenshots
	uses: actions/upload-artifact@v3
	if: always()
	with:
	name: mysql-test-screenshots
	path: /home/runner/work/etd/etd/tmp/test-screenshots.tar

Provide feedback