Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy --all-targets #335

Merged
merged 2 commits into from
Dec 27, 2024
Merged

clippy --all-targets #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4f38d2
clippy --all-targets
danielnorberg Dec 23, 2024
655e6ec
silence benign lint errors in test code
danielnorberg Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: format check
run: cargo fmt --all -- --check
- name: clippy check
run: cargo clippy -- -D warnings
run: cargo clippy --all-targets -- -D warnings
check-deps:
name: check-deps
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions spanner/tests/change_stream_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ fn init() {
let _ = tracing_subscriber::fmt().with_env_filter(filter).try_init();
}

#[allow(dead_code)]
#[derive(Debug)]
struct ChangeRecord {
pub data_change_record: Vec<DataChangeRecord>,
Expand All @@ -44,6 +45,7 @@ impl TryFromStruct for ChangeRecord {
}
}

#[allow(dead_code)]
#[derive(Debug)]
struct ChildPartitionsRecord {
pub start_timestamp: OffsetDateTime,
Expand All @@ -61,6 +63,7 @@ impl TryFromStruct for ChildPartitionsRecord {
}
}

#[allow(dead_code)]
#[derive(Debug)]
struct ChildPartition {
pub token: String,
Expand All @@ -76,6 +79,7 @@ impl TryFromStruct for ChildPartition {
}
}

#[allow(dead_code)]
#[derive(Debug)]
struct DataChangeRecord {
pub commit_timestamp: OffsetDateTime,
Expand Down
4 changes: 4 additions & 0 deletions spanner/tests/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ use google_cloud_spanner::bigdecimal::BigDecimal;

pub const DATABASE: &str = "projects/local-project/instances/test-instance/databases/local-database";

#[allow(dead_code)]
pub struct UserCharacter {
pub user_id: String,
pub character_id: i64,
Expand All @@ -36,6 +37,7 @@ impl TryFromStruct for UserCharacter {
}
}

#[allow(dead_code)]
pub struct UserItem {
pub user_id: String,
pub item_id: i64,
Expand All @@ -54,6 +56,7 @@ impl TryFromStruct for UserItem {
}
}

#[allow(dead_code)]
pub struct UserItemWithHistory {
pub user_id: String,
pub item_id: i64,
Expand All @@ -74,6 +77,7 @@ impl TryFromStruct for UserItemWithHistory {
}
}

#[allow(dead_code)]
pub struct UserItemHistory {
pub user_id: String,
pub item_id: i64,
Expand Down
Loading