Skip to content
This repository has been archived by the owner on Nov 19, 2019. It is now read-only.

Nested groups collapse/uncollapse not working #113

Open
strazto opened this issue Feb 1, 2019 · 5 comments
Open

Nested groups collapse/uncollapse not working #113

strazto opened this issue Feb 1, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@strazto
Copy link
Contributor

strazto commented Feb 1, 2019

Heres a jsbin

When clicking the group, the collapse/uncollapse styling seems to toggle, but besides that, there's no change.

@strazto
Copy link
Contributor Author

strazto commented Feb 1, 2019

I've looked at it more closely, and I'm finding it hard to see where the actual showing/hiding of the nested groups is handled https://github.com/yotamberk/timeline-plus/blame/master/lib/timeline/component/ItemSet.js#L1809

I'm new to javascript, though, so I may just be missing something about the way it handles events.
is it possible that this behaviour got removed, somehow?

@yotamberk yotamberk added the bug Something isn't working label Feb 2, 2019
@strazto
Copy link
Contributor Author

strazto commented Feb 4, 2019

Yo I fixed it but I also added dependencies on js-logger, js-logger-babel, and on jest and testcafe.

I'm not sure if you're open to a PR with all these new dependencies.

I'm pretty careful with commit-cleanliness and should be able to get rid of all of the logging content, but personally I'm of the opinion that a test-driven policy might be of benefit for maintaining this package, since it seems like you're dealing with regression bugs quite regularly.

I'll make the PR, please get back to me either way

@strazto
Copy link
Contributor Author

strazto commented Feb 4, 2019

EDIT, fixed it again, properly this time #119

@sbusch
Copy link
Contributor

sbusch commented Mar 19, 2019

Wrapping the groups in a DataSet resolves the problem: JS Bin

@strazto
Copy link
Contributor Author

strazto commented Mar 31, 2019

@sbusch , interesting note.

It does fix the behaviour, and seems simpler than my fix, but it still indicates buggy behaviour, right? At some point are the groups not being treated as DataSets

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants