-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
Unselect only ids of items that are not selected anymore
Fixed Folding Nested Groups
I sincerely appreciate this PR, but I don't want to introduce such a huge change in 1 PR. |
Thanks @yotamberk , will do. |
@mstr3336 Any update? |
sorry, yotamberk, things got pretty busy in my life so the most i did for this is think about it occasionally and feel guilty.
Just confirming, you're okay with logging statements if they're also in a separate PR?
I'll try to get on this in the next few days
…________________________________
From: Yotam Berkowitz <[email protected]>
Sent: Sunday, March 10, 2019 5:17:28 AM
To: yotamberk/timeline-plus
Cc: Matthew Mark Strasiotto; Mention
Subject: Re: [yotamberk/timeline-plus] Nest order (#119)
@mstr3336<https://github.com/mstr3336> Any update?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#119 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AlmTQot8Nofj07khrOOpvXGYjp1My41eks5vU_q4gaJpZM4aiRfT>.
|
No hard feelings! I myself am not too available for this project and truly understand the guilt feelings... Whenever you get around to this, it would be highly appreciated. I can implement your changes myself if you'd like, but I don't want to do it because I'd like you to have a commit in this project 😄
Yup! |
@yotamberk , my god this has taken me a long time to get to. |
Hey @yotamberk , see #149 and #150 for a much cleaner commit history + less busy PRs! Let's pretend it didn't take me 2 months :'( |
Fixed nested group fold/unfold.
Added UI testing deps, logging dependencies, unit testing deps (IMO all necessary/ of use)