Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-321: Origins > Shared > Create the dropdown select component #171

Merged
merged 14 commits into from
Jan 23, 2025

Conversation

ibrilBadreddine
Copy link
Contributor

@ibrilBadreddine ibrilBadreddine commented Jan 22, 2025

JIRA Ticket

Ticket: TH-321.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

Important

Please read the ticket description for more details.

QA Steps

  • Go to {your_store_slug}.youcan.shop
  • Syntaxt:
<yc-select name="fruit">

  <yc-select-trigger class="yc-btn icon" arai-label="select trigger">
    <yc-select-value>Please select a value</yc-select-value>
  </yc-select-trigger>

  <yc-select-content>
    <yc-select-item value="banana">Banana</yc-select-item>
    <yc-select-item value="apple">Apple</yc-select-item>
    <yc-select-item value="orange">Orange</yc-select-item>
  </yc-select-content>

</yc-select>
  • Preview:
Screenshot 2025-01-22 at 15 50 24

Note

Leave empty when you have nothing to say.

@ibrilBadreddine ibrilBadreddine added the in progress Currently being developed. label Jan 22, 2025
@ibrilBadreddine ibrilBadreddine self-assigned this Jan 22, 2025
@ibrilBadreddine ibrilBadreddine added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Jan 22, 2025
themes/origins/assets/component-select.js Outdated Show resolved Hide resolved
themes/origins/assets/component-select.js Show resolved Hide resolved
themes/origins/styles/component-select.scss Outdated Show resolved Hide resolved
@eihabkhan eihabkhan added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Jan 23, 2025
@ibrilBadreddine ibrilBadreddine merged commit 2006ad6 into rabi3a Jan 23, 2025
@ibrilBadreddine ibrilBadreddine deleted the TH-321 branch January 23, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants