Fix username clobbering in mongodb_uri #808
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to get mongo-connector to authenticate with mongodb as the origin using x509 auth. When calling with username on the command line, i.e.,
mongo complains
mongo_connector.errors.InvalidConfiguration: Admin username specified without password.
When calling with the username as part of the mongo uri, i.e.,
the username gets clobbered by
connection.copy_uri_options()
and the server rejects the connection.This PR updates
connection.copy_uri_options()
to not clobber usernames and passwords. I haven't tested it with anonymous or any other type of authentication, but I believe it should work.Note, using x509 auth with mongo as the destination db does not have this bug.