-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added specs #1
Open
arizz96
wants to merge
13
commits into
your:master
Choose a base branch
from
arizz96:fix_spec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added specs #1
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ed84752
fixed bug on date
arizz96 b1b99a2
added spec for previous_weeks
arizz96 2c2fc44
added spec for next_weeks
arizz96 e9c1676
added spec for past_only param
arizz96 fa9152b
added exception when using with wrong params
arizz96 1781bd5
added spec for initializer of week picker
arizz96 95475d9
added test on steps variable
arizz96 4e0120a
added test for minus and plus operands
arizz96 377a3c6
added test for reset! method
arizz96 a509dab
added test for _offset_anchor private method
arizz96 bd0b8b6
added test for _reset_steps private method
arizz96 77eb601
added test for _reset_offset private method
arizz96 2088fcb
corrected descriptions
arizz96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ def initialize(anchor: nil, past_only: true) | |
@steps = 0 | ||
@anchor = anchor | ||
@past_only = past_only | ||
raise ArgumentError if @anchor.nil? | ||
raise ArgumentError if @anchor.nil? || [email protected]_a?(Time) | ||
|
||
_offset_anchor | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!