Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Badge 관련 story, type 이름 수정 #11

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix: Badge 관련 story, type 이름 수정 #11

merged 2 commits into from
Oct 4, 2023

Conversation

nijuy
Copy link
Collaborator

@nijuy nijuy commented Oct 4, 2023

1️⃣ 어떤 작업을 했나요? (Summary)

기존 코드에 영향을 미치지 않는 변경사항

  • StyledBadgeProps 타입의 속성 앞에 $를 붙였습니다 (관련 노션)
  • Badge 관련 스토리 이름을 파스칼 케이스로 수정했습니다

* StyledBadgeProps 타입의 속성명 앞에 $를 추가했습니다
* Badge 관련 story 이름을 PascalCase에 맞게 수정했습니다
Copy link
Member

@Hanna922 Hanna922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 $ 안 붙은지 모르고 있었네요 ㅋㅋㅋㅋㅋ 수고하셨숩니당👍🏻👍🏻

@nijuy nijuy merged commit 2384cac into develop Oct 4, 2023
1 check passed
@nijuy nijuy deleted the feat/badge branch October 4, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants