Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Textarea 컴포넌트 구현 #150
feat: Textarea 컴포넌트 구현 #150
Changes from 17 commits
43ef88c
afb1018
39342f1
1896852
9346d0c
360a374
3a106d8
b4ade14
68640e1
31b354b
edf0eca
e16a681
d3cc9ff
ae0e28e
c92abeb
f878050
8c9b2ad
c0a8521
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스크롤이 생겼을 때 디자인이 아직 적용 전인거 같네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스타일 적용해서 반영해두겠습니당! 근데 제가 맥인데 보리가 윈도우 스타일 잘 적용됐는지 추후 수정되면 한번 확인해주심.. 감사하겠숨다😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nijuy 스크롤바 적용 완료하였습니다! 이게 스크롤바 적용이 패딩값을 무시하고 textarea 전체에 맞게 스크롤바가 생겨서
StyledTextareaWrapper
로 감싸서 패딩값 적용된 컨테이너 안에 스크롤바가 생긴 형태(피그마와 같은 형태)로 작업하였습니다!윈도우 환경 확인 부탁드려욥!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
잘 보입니다!
다만 첫번째 사진은 단어 길이 때문에 줄바꿈이 생겨서 스크롤과 단어 사이 여백이 충분한데,
그렇지 않은 경우에 글자랑 스크롤바 사이가 너무 딱 붙어있어서..🥲
디자인 자체가 1로 되어있어서 줄바꿈이 안 일어나는 경우 글자와 스크롤 사이 여백이 고려됐는지 잘 모르겠네요!
한번 물어보는 건 어떨까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6px이라네용 굿.........
바로 머지할 수 있게 미리 어푸룹 해둘게요 이거 말곤 진짜진짜 안보임!!!!